search

ngauthier / tubesock

Websocket interface on Rack Hijack w/ Rails support
MIT License
620 stars 43 forks source link

handle Puma::MiniSSL::Socket no method issue #35

Closed leckylao closed 9 years ago

leckylao commented 10 years ago

handle Puma::MiniSSL::Socket no method issue

leckylao commented 10 years ago

https://github.com/ngauthier/tubesock/issues/34

leckylao commented 10 years ago

https://github.com/ngauthier/tubesock/issues/33

ngauthier commented 10 years ago

Thank you! But can you please use respond_to?(:method) instead of checking the class? Because people who don't use puma will get an exception. You can see this if you look at the Travis build.

Also, please create a test such that the puma path is hit (by making a fake socket or something). I hope to maintain our current level of code coverage.

Nick

leckylao commented 10 years ago

Thank you @ngauthier for pointing it out.

ghost commented 10 years ago

shouldn't addrinfo be set through @socket.peeraddr?(http://www.rubydoc.info/github/puma/puma/Puma/MiniSSL/Socket#peeraddr-instance_method)

since readpartial seems not to return the addrinfo (http://www.rubydoc.info/github/puma/puma/Puma/MiniSSL/Socket:readpartial)

I ran into the same issue today

leckylao commented 10 years ago

Good spot @alexandermayr

teddythetwig commented 9 years ago

I hope this PR is merged soon, this is the only thing preventing me from using tubesock atm.

ngauthier commented 9 years ago

Sorry I hadn't checked on it in a while!

Version 0.2.5 released. Thanks @leckylao!

teddythetwig commented 9 years ago

Thanks @ngauthier @leckylao