search

ngauthier / tubesock

Websocket interface on Rack Hijack w/ Rails support
MIT License
620 stars 43 forks source link

call readpartial and peeraddr on @socket if available to support puma's ... #36

Open ghost opened 10 years ago

ghost commented 10 years ago

same solution as https://github.com/ngauthier/tubesock/pull/35 but with setting addrinfo through @socket.peeraddr

ngauthier commented 10 years ago

Awesome, much shorter. Could you add a test that covers the scenario where we have a different kind of socket?

ghost commented 10 years ago

I found some more issues with puma's ssl socket, will fix them as well and add the test afterwards

ngauthier commented 10 years ago

thanks!

On Wed, Nov 12, 2014 at 9:41 AM, alexandermayr notifications@github.com wrote:

I found some more issues with puma's ssl socket, will fix them as well and add the test afterwards

— Reply to this email directly or view it on GitHub https://github.com/ngauthier/tubesock/pull/36#issuecomment-62727225.