search

ngauthier / tubesock

Websocket interface on Rack Hijack w/ Rails support
MIT License
620 stars 43 forks source link

Rails5 patch from gosukiwi #56

Closed cantino closed 6 years ago

cantino commented 6 years ago

Hey @ngauthier, this PR incorporates the fixes from @gosukiwi in #55. The tests are now passing, although I'd like you to sanity check the changes I made. It also fixes a few warnings.

gosukiwi commented 6 years ago

Nice, thanks for your work 👍 Hope this gets merged

ngauthier commented 6 years ago

Thanks!

cantino commented 6 years ago

Thanks @ngauthier. Would you be able to push an update to RubyGems?

ngauthier commented 6 years ago

v0.2.8 is released!

On Thu, Sep 13, 2018 at 8:25 PM Andrew Cantino notifications@github.com wrote:

Thanks @ngauthier https://github.com/ngauthier. Would you be able to push an update to RubyGems?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ngauthier/tubesock/pull/56#issuecomment-421192575, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA1VimPrjHqeKe-RJvq5ZbaSfSVifi-ks5uavdbgaJpZM4Wn8b8 .