ngauthier / tubesock

Websocket interface on Rack Hijack w/ Rails support
MIT License
620 stars 43 forks source link

Exception in keepalive will kill the process #58

Closed joshleblanc closed 5 years ago

joshleblanc commented 5 years ago

keepalive spawns a new thread with abort_on_exception = true. There's no error handling for this threads, and since it's a thread, you can't wrap the listen call with a rescue block.

If an exception is raised in this thread, it will kill the entire process.

Notably, we're getting an Errno::ECONNRESET in the keepalive thread.