ngbinh / gradle-scalastyle-plugin

Gradle plugin for scalastyle
18 stars 16 forks source link

Support scala 2.12 #31

Closed otrosien closed 6 years ago

otrosien commented 7 years ago

Please add scala 2.12 support with the next release.

jcranky commented 7 years ago

Any plans for this to actually happen?

srmds commented 7 years ago

Any plans for the above plans to add support for Scala 2.12? Would be highly appreciated :)

tomnis commented 6 years ago

we'd really like 2.12 support also :)

ngbinh commented 6 years ago

ok, will try to get this done soon.

ngbinh commented 6 years ago

https://github.com/ngbinh/gradle-scalastyle-plugin/commit/94d5ecc655555efb8705f4f6f2344a897afd7d68

jcranky commented 6 years ago

Thanks :)

jcranky commented 6 years ago

@ngbinh Is this published yet or when would it be published? :)

ngbinh commented 6 years ago

Let me check when I get home

jcranky commented 6 years ago

Thanks again :)

ngbinh commented 6 years ago

should be available here https://bintray.com/ngbinh/maven/gradle-scalastyle-plugin_2.12/1.0.0 . I forgot to push the button, sorry for that!

tomnis commented 6 years ago

cool, thanks a lot :)

tomnis commented 6 years ago

hi @ngbinh sorry, but it looks like this new published artifact is not resolvable from jcenter.

 > Could not find org.github.ngbinh.scalastyle:gradle-scalastyle-plugin_2.12:1.0.0.
     Searched in the following locations:
         https://jcenter.bintray.com/org/github/ngbinh/scalastyle/gradle-scalastyle-plugin_2.12/1.0.0/gradle-scalastyle-plugin_2.12-1.0.0.pom
         https://jcenter.bintray.com/org/github/ngbinh/scalastyle/gradle-scalastyle-plugin_2.12/1.0.0/gradle-scalastyle-plugin_2.12-1.0.0.jar

I have a small example buildscript here: https://github.com/tomnis/scalastyle-gradle-not-resolved

Looking at the 2.12 artifact in bintray, I don't think its linked to the jcenter repository: screenshot 2017-10-05 13 03 39

The older 2.11 artifacts are linked to jcenter: screenshot 2017-10-05 13 06 47

Could you link the new 2.12 artifact to jcenter please?

jcranky commented 6 years ago

Linking to jcenter would be useful indeed. In the meanwhile, I managed to use it by adding this to my build.gradle file, in the buildscript.repositories section:

maven {
    name = "ngbinh"
    url = "https://dl.bintray.com/ngbinh/maven"
}
ngbinh commented 6 years ago

I already made the request for the 2.12 artifact to be linked. Hopefully it will appear there soon. In the mean time, please use @jcranky workaround.

gregadevinta commented 6 years ago

Any chance of publishing for 2.11 too, with the latest fix?

howyp commented 6 years ago

Hey @ngbinh, I still can't see the 2.12 artifact in JCenter :-( Would you be able to check what's up, please?

ngbinh commented 6 years ago

@howyp I already see this screen shot 2017-11-17 at 6 13 56 pm

Not sure what else I have to do?

ngbinh commented 6 years ago

@gregschibsted will do this week.

howyp commented 6 years ago

Hmmm that's odd. I see this in JCenter:

screen shot 2017-11-17 at 11 23 19