ngbolt / ng-bolt

Front-end framework built on AngularJS for rapid development of responsive web applications.
https://ngbolt.github.io
Other
4 stars 2 forks source link

Refactor and normalize ngBolt component attributes #49

Closed theJuddson closed 7 years ago

theJuddson commented 7 years ago

Refactor all usages of our internal blt attribute directive to use the built-in ng-attr directive. This should resolve some of the attribute related bugs that we've been experiencing. (Issues #34 and #30)

Ensure consistent attribute availability and binding across all components. Bind with one way model binding '<', when possible, falling back to DOM attribute binding '@' for components that will almost always be defined with a string literal. The goal here is to ensure that binding type ('<', '&', '@') is consistent for each attribute across all components, and avoid requiring the developer to use interpolation {{}} to provide attribute values whenever possible.

theJuddson commented 7 years ago

The components that will need to be refactored are:

Text field has been completed already in the issue_34_attribute_refactor branch. Please use that component as a reference point.

The following attributes should be shared across all components. Please add/update all other components to include these attributes ensuring the binding is as specified here.

Several different components use 'min' and 'max' attributes. Please ensure that these are consistent with the Text Field.

You can also review the additional attributes that are specified on the Text Field component to see if any apply to other components, however most of them will not apply.