ngbracket / ngx-layout

Clone of the Angular FlexLayout
MIT License
184 stars 11 forks source link

fix(browser-tools): update config #34

Closed DuncanFaulkner closed 10 months ago

alexmurari commented 10 months ago

@DuncanFaulkner look at this comment https://github.com/CircleCI-Public/browser-tools-orb/issues/90#issuecomment-1699879803

- browser-tools/install-browser-tools:
          chrome-version: 116.0.5845.96
          replace-existing-chrome: true <-- Add this

CircleCI is a little stubborn, huh?

DuncanFaulkner commented 10 months ago

I tried replace-existing but not with the chrome part will try that later tonight, thanks for your help on this much appreciated

DuncanFaulkner commented 10 months ago

Hi

As luck would have it Circle CI released orbs 1.4.5 - that now works - just can't test saucelabs I will need to look into that

Duncan Faulkner | Angular Developer

Angular Certified Developer II, MCP, MCSD, MCAD.Net, AZ-900


From: Alexandre Murari Junior @.> Sent: 05 September 2023 13:10 To: ngbracket/ngx-layout @.> Cc: Duncan Faulkner @.>; Mention @.> Subject: Re: [ngbracket/ngx-layout] fix(browser-tools): update config (PR #34)

@DuncanFaulknerhttps://github.com/DuncanFaulkner look at this comment CircleCI-Public/browser-tools-orb#90 (comment)https://github.com/CircleCI-Public/browser-tools-orb/issues/90#issuecomment-1699879803

CircleCI is a little stubborn, huh?

— Reply to this email directly, view it on GitHubhttps://github.com/ngbracket/ngx-layout/pull/34#issuecomment-1706503771, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAO4S5ET3ZEX3DTTF6SF4PDXY4JFHANCNFSM6AAAAAA4LJ22BY. You are receiving this because you were mentioned.Message ID: @.***>

alexmurari commented 10 months ago

Well, that's a start. 😄

I don't know anything about SauceLabs testing; but I'll try to help and see what I can find.

DuncanFaulkner commented 10 months ago

Same, again thanks for your help really appreciated