search

ngbracket / ngx-layout

Clone of the Angular FlexLayout
MIT License
196 stars 12 forks source link

fix(media-observer) honor nonce in style tag(#38) #39

Closed yogeshgadge closed 1 year ago

yogeshgadge commented 1 year ago

Fixes #38 both browser and universal

DuncanFaulkner commented 1 year ago

@yogeshgadge thanks for the PR really appreciate your support. Are you able to add unit tests to cover this?

Thanks

yogeshgadge commented 1 year ago

That part os code is not quite unit testable - I went for it initially but gave up since the fix is in the private/un-exported functions (buildQueryCss) not implicitly unit tested obviously. Having said that I might be able to query document and use side effects. Let me see what I can do without exposing that function.

yogeshgadge commented 1 year ago

added unit test

DuncanFaulkner commented 1 year ago

@yogeshgadge thanks for your support on this, I will try and add your PR and create a release in the next few days.