search

ngbracket / ngx-layout

Clone of the Angular FlexLayout
MIT License
196 stars 12 forks source link

ngClass API broken in latest AngularBuild (17.0.5)? #49

Closed mnesser closed 8 months ago

mnesser commented 8 months ago

Bug Report

What is the expected behaviour?

ngClass.lt-md="classX" should add the class when the screen size matches the conditon (screen and (min-width: 1280px))

What is the current behaviour?

page not loading and and a error is logged in the console error: TypeError: this._renderer.addClass is not a function)

What are the steps to reproduce?

Providing a StackBlitz (or similar) is the best way to get the team to see your issue. Unable to provide StackBlitz The entrypoint for '@ngbracket/ngx-layout' could not successfully be resolved. The file '/turbo_modules/@ngbracket/ngx-layout@16.1.3/index.js' does not exist. Please log an issue with the package author or check for an updated version of the package.

DuncanFaulkner commented 8 months ago

Thanks for the bug report, not sure what's happening here, I might need to update the package to the latest version of Angular to see if I can recreate it.

DuncanFaulkner commented 8 months ago

@mnesser I just updated the project locally and it looks like something has changed in the NgClass, will need to investigate further to find out what's going on will keep you posted.

DuncanFaulkner commented 8 months ago

@mnesser It looks like the Angular team has removed some parameters from NgClass that were used by Angular Flex-Layout.

@skovalyov has suggested a workaround on this PR 53831 that might get you around your issue, assuming you're not using the extendModule and don't require support for responsive breakpoints, if you do you will need to roll back to Angular 17.0.8