Update Angular version and fix NgClass directive

ngbracket / ngx-layout

Clone of the Angular FlexLayout

MIT License

196 stars 12 forks source link

Update Angular version and fix NgClass directive #50

Closed skovalyov closed 8 months ago

skovalyov commented 8 months ago

Fix proposal for ngx-layout/issues#49

In angular/angular#53831 NgClass directive constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removing iterableDiffers and keyValueDiffers, which are not used anymore.

DuncanFaulkner commented 8 months ago

@skovalyov thanks for the PR, I was looking at this over the weekend and thought that this seemed like the obvious solution, but it just felt too easy, plus I wasn't sure if that would break anything else, though all unit tests passed.

I will merge your PR into main and into the 17 branch as soon as I can, again thanks for the PR

minijus commented 8 months ago

There is release tag in GH, but v17.0.1 is missing in npm.

DuncanFaulkner commented 8 months ago

@minijus I had pushed the GH release but it was getting late and just didn't get to it - will try and do it now,