ngdeleito / easyGestures

A WebExtension for Firefox providing easy to learn gestures through a highly customizable pie menu
https://addons.mozilla.org/en-US/firefox/addon/easygestures-n/
10 stars 1 forks source link

Click-hold-release action is activating the secondary menu option #10

Open dkwarr87 opened 6 years ago

dkwarr87 commented 6 years ago

I've noticed an issue that seems to have begun occurring a few days ago. I use easyGestures by holding the middle mouse button, moving the mouse towards the action I want to activate and then releasing the button. I have my menu set up so that Page Top is in the Top-Left position on the primary menu, and Undo Close Tab is in the same position on the secondary menu. When I use click-hold-release on the Page Top action, it is instead triggering the Undo Close Tab action on button release. If I click-release to activate the menu, then click-release to trigger the Page Top action it works fine. I'm afraid it isn't consistent with when this happens, and it doesn't happen every time, but it is reproducible for me.

Steps To Reproduce:

  1. Click and Hold middle mouse button
  2. Move mouse to pie menu action
  3. Release middle mouse button

Expected Result: The Pie menu action shown in the primary menu should be activated

Actual Result: The Pie menu action shown in the secondary menu is activated instead

System Info: Firefox 61.0.2 (64-bit) Windows 7 easyGestures N 6.0 (updated 30 July 2018)

dkwarr87 commented 6 years ago

Actually, this might just be a dodgy mouse triggering extra click events, will re-test with a different mouse

ngdeleito commented 6 years ago

Thanks for the detailed and very clear problem description.

I have never experienced that problem on macOS but I am experiencing a similar one: click-hold-release has sometimes no effect at all, while click-release-pointing the action-click-release works. I am unable to reproduce it, but, for some reason, the mousemove event handler is not called.

I will keep investigating this taking your problem into account. Hope I can find a solution or workaround. Let me know if the problem disappears with a different mouse.

dkwarr87 commented 6 years ago

Seems my particular issue was just caused by a dodgy mouse, but I'm glad it helped you find another issue. Happy to close this issue if you wish or can leave it open to track the other one.

ngdeleito commented 6 years ago

Great to hear that your problem was solved! I'll keep the issue open as a reminder for further investigation of the other issue.