ngedwin98 / ABCDBeamTrace.jl

ABCD formalism for linear optics in Julia: ray transfer matrices and Gaussian beam propagation
Other
9 stars 3 forks source link

Alternatives to `waistradiusfunc` #8

Open ngedwin98 opened 5 years ago

ngedwin98 commented 5 years ago

See the discussion in PR #5. It is useful to provide functionality for evaluating the beamtrace at arbitrary locations. This is also involved with the question of how best to represent the beamtrace visually as well. Currently, waistradiusfunc provides an alternative to the (very rudimentary) approach using discretize. However, I think discussion should continue about the best way to achieve these goals. This issue serves as a way to collect such ideas as more experimentation is done.

ghost commented 5 years ago

Your suggestion of a spotradius is perfect. In fact, I've already changed it in my fork (see https://github.com/Quantum-Factory/ABCDBeamTrace.jl/commit/799ce4d415dd0c901cfd6a06f8f23936df590018). Of course, that doesn't answer the question with what to replace (and if to replace) spotradiusfunc, as I naturally renamed that one.

ngedwin98 commented 5 years ago

Excellent, spotradius it is then. However, I think it is still worth considering whether there are further improvements we can make to streamline the functionality currently provided by spotradiusfunc. When I have some time to try out some alternatives, I will reference them here.