search

ngeelani48 / Recipe-app

The Recipe app keeps track of all your recipes, ingredients, and inventory. It will allow you to save ingredients, keep track of what you have, create recipes, and generate a shopping list based on what you have and what you are missing from a recipe.
MIT License
1 stars 1 forks source link

Setup Kanban Board #16

Open lawrahkonwea opened 1 year ago

lawrahkonwea commented 1 year ago

Hello there....

In this Ruby on Rails project we are teams of three:

Here is the link to our project page

TedLivist commented 1 year ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @lawrahkonwea, @Ridwanullahi-code and @ngeelani48,

Good job so far! ✔️ Kanban columns are complete ✔️ Tasks are well assigned However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

lawrahkonwea commented 1 year ago

Thank you for the review @TedLivist. We will implement the requested changes.

Abenezer-Tilahun commented 1 year ago

Hi @lawrahkonwea @ngeelani48 @Ridwanullahi-code

Your project is complete 👍 💯 There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights 👏🏻

✔️ Good job for provide the information about the number of people in their group ✔️ Good Job for provide link to their GitHub project ✔️ Good job for implementing RoR group project: set up your Kanban board

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.