soc-se-bot
commented
12 months ago Team's Response
Error is not parsing the wrong policy value properly and hence not showing a proper error message
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
adding policy with missing space character does not show correct error message
command given: 'addPolicy 1 pn/Health Insurance pd/Cancer Plan pv/2000.00psd/2023-01-01 ped/2024-12-12'
[original: nus-cs2103-AY2324S1/pe-interim#2385] [original labels: type.FeatureFlaw severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Acknowledged that I could have defensive coded this to provide an error when no spacing was provided between prefixes
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: Different command format than the other bug.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This functionality does not work as expected. Error messages are supposed to be shown for events / commands that fail. In this case, by not showing the message, the functionality of the feature is not complete.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Medium: A flaw that causes occasional inconvenience to some users but they can continue to use the product. This bug will result in inconvenience to users as they would think that the command is successful, but there is no indication that this command has failed.
addPolicy command with more than 8 digits for pv doesnt show any error message. and nothing occurs in the app.
Test steps:
addPolicy 2 pn/Health Insurance pd/Cancer Plan pv/20000000 psd/2023-01-01 ped/2024-12-12(the success message above is for a previous command)