ngeeyonglim / pe

0 stars 0 forks source link

Inconsistent error message for removePolicy command #12

Open ngeeyonglim opened 12 months ago

ngeeyonglim commented 12 months ago

Screenshot 2023-11-17 at 5.07.31 PM.png

Inconsistent error message for removePolicy command.

Screenshot 2023-11-17 at 5.08.26 PM.png

nus-pe-bot commented 12 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Viewing policies with invalid contact index yields different error messages

Different error message for index 0 and 999 for contact index when viewing policies image.png

image.png


[original: nus-cs2103-AY2324S1/pe-interim#2370] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

as can be seen in the screen shot policy index has to be a positive integer, 0 is not a valid positive integer, the user guide also explicitly stated the range of values is 1 to 2147483647, hence it will return different error as one is saying that it is a invalid integer and hence return invalid command and another is that it is valid but there is no policy and hence return invalid index

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2023-11-21 at 6.22.42 PM.png](https://raw.githubusercontent.com/ngeeyonglim/pe/main/files/d0d27767-670a-4195-a913-399868c83fef.png) This is a bug as the error message is not specific enough. The error message doesnt give the reason why the error is occurring. According to CS2103 guidelines, this is a severity Low feature flaw bug.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2023-11-21 at 6.24.34 PM.png](https://raw.githubusercontent.com/ngeeyonglim/pe/main/files/898a6d1d-a7a5-4cfd-a451-7cfa742b282a.png) According to CS2103T guidelines, this is a severity low bug.