ngeeyonglim / pe

0 stars 0 forks source link

Restrictive input usage for PMR prefix #4

Open ngeeyonglim opened 12 months ago

ngeeyonglim commented 12 months ago

Screenshot 2023-11-17 at 4.21.37 PM.png

The app only allows for uncapitalised strings, and is not generalised to accept capital letters.

Screenshot 2023-11-17 at 4.23.15 PM.png

nus-pe-bot commented 12 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitiveness of preffered meeting region value lowers users' experience

Steps to reproduce: Enter the following command:

  • add n/BetsyCrowe p/92222222 e/betsycrowe@example.com a/Newgate Prison t/friends pmr/North

The command execution fails as the pmr provided is not precisely north.

Screenshot 2023-11-17 at 4.49.12 PM.png

Problematic behaviour:

North and north are generally used interchangeably and some users might be used to typing in North when specifying a region. Blocking such inputs will not bring value to the user but allowing it will.


[original: nus-cs2103-AY2324S1/pe-interim#3308] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Error message clearly indicates to type command in small case. This is a feature that we intent to reduce the case sensitivity in the future. Due to the feature freeze, we can only keep the current feature and leave it to improve in the future.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Not purely cosmetic, affects usage of the app.