search

ngeeyonglim / pe

0 stars 0 forks source link

Allows for addition of duplicate persons #5

Open ngeeyonglim opened 12 months ago

ngeeyonglim commented 12 months ago

Screenshot 2023-11-17 at 4.29.01 PM.png

Steps:

  1. Make sure "Bernice Yu" is present in the contact list
  2. add a new person with name "bernice yu" in the contact list

The app allows for the addition of bernice yu as a separate person even though names are supposed to be unique.

Screenshot 2023-11-17 at 4.28.19 PM.png

soc-se-bot commented 12 months ago

Team's Response

We feel that restricting case sensitivities can be left for future.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding duplicate names allowed if the names had different case sensitiveness

Steps to reproduce: Add two entries with the same name but with different cases, an example is as follows:

  • add n/Betsy Crowe p/92222222 e/betsycrowe@example.com a/Newgate Prison t/friends pmr/north

  • add n/BeTsy Crowe p/92222222 e/betsycrowe@example.com a/Newgate Prison t/friends pmr/north

Result: The command executes successfully and both entries are added into the application.

Screenshot 2023-11-17 at 4.23.27 PM.png

Problematic behaviour:

The application has duplicate entry detections where they will disallow duplicate entries(entries with same names), Betsy Crowe and Betsy Crowe (with 2 spaces) is generally considered to be the same name, and hence should be detected as duplicate entries.

[original: nus-cs2103-AY2324S1/pe-interim#3305] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

There might be a possibility that Betsy Crowe and BeTsy Crowe are 2 different people.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** It is stated in the screenshot provided in the original bug that this is a feature flaw, according to CS2103 standards.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This is important as users might not always be able to get the correct capitalisation of users names, and will cause minor inconvenience to users. Medium severity: A flaw that causes occasional inconvenience to some users but they can continue to use the product.