search

ngeeyonglim / pe

0 stars 0 forks source link

Name does not allow for symbols #6

Open ngeeyonglim opened 12 months ago

ngeeyonglim commented 12 months ago

Test steps:

  1. Run the following command add n/John Doe s/o Kumar p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends pmr/west

Screenshot 2023-11-17 at 4.30.37 PM.png

The correct error message is shown but it is restrictive as it doesn't allow for certain symbols which are common.

Screenshot 2023-11-17 at 4.31.25 PM.png

nus-se-bot commented 12 months ago

Team's Response

can't enter names with S/O

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Validation for name causes inconvenience

For example, "abc s/o abc" is not allowed when inputting the name. This can cause inconvenience as "s/o" is common in people's legal name.

Also, pure numeric names are allowed, which may not be intended.

[original: nus-cs2103-AY2324S1/pe-interim#5996] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The team fully takes responsibility that we overlooked the possibility that singapore names could contain S/O.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]