Avoid mutating 'times' array on sort

ngerritsen / timiks

GNU General Public License v3.0

13 stars 5 forks source link

Avoid mutating 'times' array on sort #55

Closed pyko closed 3 years ago

pyko commented 3 years ago

Hello, Realised I made a mistake in previous PR! sort mutates the original array which means if the user switches the setting without refreshing the page, odd things can happen.

Small update to fix the bug.

pyko commented 3 years ago

@ngerritsen hello, any chance you could have a look at this? Made a small mistake in previous PR, and this is a follow up PR to fix it.

Luckily seems like the build deploy pipeline didn't work for the previous PR so that change didn't get deployed.

Thanks!