search

ngfelixl / nodeplotlib

NodeJS plotting library for JavaScript and TypeScript. On top of plotly.js. Inspired by matplotlib.
https://www.npmjs.com/package/nodeplotlib
MIT License
195 stars 24 forks source link

Fix net::ERR_CONTENT_LENGTH_MISMATCH #45

Closed Moumouls closed 3 years ago

Moumouls commented 3 years ago

Closes #20

ngfelixl commented 3 years ago

Hi @Moumouls, this has been an open issue for a long time, thank you a lot for submitting a fix. You've named your commit wip. Is it still work in progress? Otherwise could you please rename the commit message to the following?

fix: content length mismatch

Closes #20

Just in case: git commit --amend, edit+save+close, force push. If it is not in wip, I start reviewing. Did the formatting happen due to auto-format?

Moumouls commented 3 years ago

It's not a wip, sorry for the commit naming, because during the fast patch, I switched from my branch to master to check that the new test correctly fail on master, I sent a wrong commit message :)

Moumouls commented 3 years ago

And yes i always forget that i have prettier activated by default...

@ngfelixl if you want i can add a simple prettier config