search

nghialv / Hakuba

:cherry_blossom: Cellmodel-driven tableview manager
MIT License
474 stars 40 forks source link

Swift3 conversion #48

Open eskizyen opened 7 years ago

eskizyen commented 7 years ago

Converted the code to Swift 3.0, example project runs without any problem.

gorbat-o commented 7 years ago

Hi, It's working for me, verify the travis conf if it's swift 3 ? thanks for update to 3 see ya

ra1028 commented 7 years ago

I think you should add @discardableResult to some functions that required it.

eskizyen commented 7 years ago

@ra1028 I updated the project according to your notes. Thanks for the review.

ra1028 commented 7 years ago

@eskizyen I think, there are more functions that which you should to add @discardableResult! 🙇