search

nghialv / MaterialKit

Material design components for iOS written in Swift
MIT License
2.51k stars 290 forks source link

Make compatible with swift 3 and xcode 8 #63

Closed giaotuancse closed 5 years ago

giaotuancse commented 7 years ago

Currently does not compile in Xcode 8 due to swift 3 compatibility

jayvenn commented 7 years ago

Bump! Please update

idrisyildiz7 commented 7 years ago

Please update.. I am waiting for...

faresbh commented 7 years ago

64

PhilippeBoisney commented 7 years ago

Thanks @faresbh for your PR ! I've just updated my podfile with your repo : pod 'MaterialKit', :git => 'https://github.com/faresbh/MaterialKit', :branch => "swift3" Seems to work !

iteamtech commented 7 years ago

compatible with swift3

ghost commented 7 years ago

Any update on when would this be fixed? I am stuck with MaterialKit not working on Xcode 8.1 and Swift 3... Getting these errors:

  1. MKLayer.swift:98:24: Method does not override any method from its superclass

    open override func animationDidStop(_ anim: CAAnimation, finished flag: Bool) {

  2. MKLayer.swift:251:40: Cannot assign value of type 'MKLayer' to type 'CAAnimationDelegate?'

    opacityAnim.delegate = self

  3. MKLayer.swift:272:34: Cannot assign value of type 'MKLayer' to type 'CAAnimationDelegate?'

    scaleAnim.delegate = self

Aneesh9090 commented 7 years ago

Any Update regarding the errors that is been mentioned by @sategroup . I'm also stuck with the same errors.

ghost commented 7 years ago

Something's wrong with the repo

Sent from my iPhone

On 19-Dec-2016, at 6:24 PM, Aneesh9090 notifications@github.com wrote:

Any Update regarding the errors that is been mentioned by @sategroup . I'm also stuck with the same errors.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Aneesh9090 commented 7 years ago

@sategroup you have any work around for the same ?

ghost commented 7 years ago

Yeah, followed suggestion given by @PhilippeBoisney and changed the url to following in the pod file

pod 'MaterialKit', :git => 'https://github.com/faresbh/MaterialKit', :branch => "swift3"

On Mon, Dec 19, 2016 at 6:50 PM, Aneesh9090 notifications@github.com wrote:

@sategroup https://github.com/sategroup you have any work around for the same ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nghialv/MaterialKit/issues/63#issuecomment-267962271, or mute the thread https://github.com/notifications/unsubscribe-auth/AVGavU-oVvqLi5iDZtnOiYt-gsf3vXxwks5rJoSXgaJpZM4J-Koc .

-- Regards