nghianm2803 / df-frontend-2023

Frontend Development Course 2023 of Dwarves Foundation.

https://www.linkedin.com/company/dwarvesf/

1 stars 1 forks source link

Submission for assignment 7 #7

Open nghianm2803 opened 11 months ago

nghianm2803 commented 11 months ago

Demo link: https://df-frontend-2023-nghianm-assignment7.vercel.app/ Features done:

All core functionalities present
Backend API integration
Login logout function
Type-safety with Orval
Data fetching with SWR

chinhld12 commented 10 months ago

Nice work,

Requirements

[x] All core functionalities present
[x] Type-safe integration with Orval

Final result: ✅

Feedback

Overall your implemented typesafe is good, just notice that some API your are not handle catch error (incase has API errors). And seem you forgot to use generated/auth from fetched Swagger to handle authentication requests

...