search

nghiavtr / FuSeq

GNU General Public License v3.0
32 stars 12 forks source link

Compilation error in dependency fmtlib (error: expected unqualified-id before numeric constant) #1

Closed ilykos closed 5 years ago

ilykos commented 5 years ago

During 'make' step inside sailfish 0.10 an error occurs breaking the installation script.

Ubuntu 18.04 / FuSeq 1.1.0

/home/<user>/Tools/fuseq/FuSeq-1.1.0/sailfish-0.10.0/include/spdlog/details/format.h:2056:24: error: expected unqualified-id before numeric constant
         const unsigned CHAR_WIDTH = 1;
                        ^~~~~~~~~~

The fix of spdlog is described here: https://github.com/fmtlib/fmt/commit/abbefd71666055daac9e14e78262620f9e845850

Bundling a more recent version of fmtlib/spdlog/sailfish will probably solve the problem.

nghiavtr commented 5 years ago

Dear ilykos,

Many thanks for your report and solution about the error of FuSeq during installation from source using Ubuntu 18.04.

Since I was successful with other versions of Linux (e.g., Ubuntu 16.04 and Centos 3.10 ), so I think it is likely that the error wass due to the Linux OS version rather than the Sailfish's codes.

For using the binary version of FuSeq in Ubuntu 18, as my experiment, it is still ok; but similarly to Ubuntu 16, it still needs to remove librt.so.1 from folder "linux/lib".

Best, Nghia