Closed GoogleCodeExporter closed 9 years ago
Sorry about the typo in the title field.
Original comment by irmendejong
on 7 Dec 2012 at 9:03
Hey,
Thanks really brilliant, thanks for that.
Instead of sending your code though, would you be interested in checking out
colorama, making the changes to colorama itself, and submitting a patch or pull
request? Then we could integrate your code right into the project!
If underline doesn't work then I'd probably not integrate that into the master
branch, so you might want to just do reverse, or at the very least do reverse
and underline as separate commits (or groups of commits.) Then we could merge
each feature into the project (or not) separately.
Don't forget to update the tests to cover your new code.
No worries if you don't have time, but much appreciated if you do.
Original comment by tart...@gmail.com
on 10 Dec 2012 at 11:05
The underlined style *does* work on linux and mac os though.
The blink style works on mac os but not on linux (may depend on the terminal
that is used).
Underlined and blink both don't work on windows console. Reversevid only works
using the emulation.
Will have a look on how much work it is to provide a true patch instead of
above monkeypatching code
Original comment by irmendejong
on 10 Dec 2012 at 11:48
Right, that was pretty easy. Please find a patch attached.
(I've removed the ITALIC style because that one seems to be supported nowhere)
Original comment by irmendejong
on 11 Dec 2012 at 12:25
Attachments:
Thanks. Remember that Colorama does precisely nothing on platforms other than
Windows - all effects are purely up to the terminal.
I'll check it out today.
Original comment by tart...@gmail.com
on 11 Dec 2012 at 7:55
Original comment by tart...@gmail.com
on 20 Apr 2014 at 9:50
Migrated to https://github.com/tartley/colorama/issues/39
Closing here as 'duplicate'
Original comment by tart...@gmail.com
on 16 Feb 2015 at 12:11
Original issue reported on code.google.com by
irmendejong
on 7 Dec 2012 at 9:00