ngi-nix / ngipkgs

Nix packages and services for projects supported through the NGI program
https://ngi-nix.github.io/ngipkgs
MIT License
35 stars 18 forks source link

openXC7 #7

Closed fricklerhandwerk closed 1 year ago

fricklerhandwerk commented 1 year ago

Free and open source FPGA toolchain for AMD/Xilinx Series 7 chips

This seems to be a non-trivial project with multiple dependencies. Break down into separate issues as needed.

hansfbaier commented 1 year ago

So another item that is left, is how to get into the devshell in a CWD independent and offline manner.

jleightcap commented 1 year ago

Nice, yeah this is a great use of the shellHook.

On Fri Oct 6, 2023 at 6:25 PM EDT, Hans Baier wrote:

Ah I found a way: image

jleightcap commented 1 year ago

It depends exactly what you mean by 'offline', but you can force nix build --offline. This of course depends on installing the dependencies at least once with network access.

As for CWD, because flakes operate over git, you can run at any place in the repository:

$ cd nix/fasm
$ nix shell .#fasm
path '/home/jleightcap/r/toolchain-nix/nix/fasm' does not contain a 'flake.nix', searching up
[***@***.***:~/r/toolchain-nix/nix/fasm]$ fasm
usage: FASM tool [-h] [--canonical] [--parser PARSER] file
FASM tool: error: the following arguments are required: file

Please let me know if that helps for each point.

On Fri Oct 6, 2023 at 6:29 PM EDT, Hans Baier wrote:

So another item that is left, is how to get into the devshell in a CWD independent and offline manner.

albertchae commented 1 year ago

Hi @hansfbaier , we're looking into your question here https://github.com/ngi-nix/ngipkgs/issues/7#issuecomment-1751446895, but I wanted to ask again

Was there anything else you needed in the toolchain-nix repo as part of the OpenXC7 toolchain (besides fasm)?

If there is a package or tool missing, please let us know.

hansfbaier commented 1 year ago

@albertchae The shellHook in the devshell, solves https://github.com/ngi-nix/ngipkgs/issues/7#issuecomment-1751446895 sufficiently. I will let you know should I have more needs. Thank you so much for your help!

albertchae commented 1 year ago

Thanks for confirming @hansfbaier ! In that case, we will close this issue for Summer of Nix tracking 🚀 Thanks again for the great collaboration

For further work outside of Summer of Nix, we should continue discussion in https://github.com/openXC7/toolchain-nix/issues/7 (which you've already commented on). Because that will be outside of the Summer of Nix, only volunteers who have interest in the project will be participating (so far @jleightcap and I).

jleightcap commented 1 year ago

https://fosstodon.org/@hansfbaier/111220127699758726 Nice to see, @hansfbaier!

albertchae commented 1 year ago

Recording for posterity, but the work for this issue is in https://github.com/openXC7/toolchain-nix

The PRs were

lorenzleutgeb commented 11 months ago

@albertchae can https://github.com/ngi-nix/toolchain-nix be archived? Or probably even better, if you don't care about the history, deleted?

jleightcap commented 11 months ago

We have two open PRs rooted from that fork.

That work is towards upstreaming into nixpkgs, and so their usefulness is dependent on if @hansfbaier finds that effort useful.

lorenzleutgeb commented 11 months ago

Okay, sorry that I missed those PRs. Then the question changes to whether the repo can be archived/deleted once both of these PRs are closed.

jleightcap commented 11 months ago

No worries, that work was outside of the scope of Summer of Nix anyways, so it shouldn't reside there. I'll wait a bit more to see if they get reviewed after the ping above, and if not, I'll move that work into a personal fork and delete https://github.com/ngi-nix/toolchain-nix.

fricklerhandwerk commented 11 months ago

@lorenzleutgeb please don't ever delete repos, only archive them. We can always link to a query that filters out archived repos.

jleightcap commented 11 months ago

I've forked the repository into my personal account. Feel free to archive. There are still active PRs based in that repository, so please don't delete.

hansfbaier commented 11 months ago

Good news: I tried the latest yosys version and it seems to work well now. Will keep on testing for a while but it looks like it is time to switch.