search

ngiachou / WalletHero

A hero we all deserve. Tracking your monthly costs was never been so much fun.
GNU General Public License v3.0
0 stars 0 forks source link

Building the class: Product #6

Closed kpaxiotis closed 6 years ago

kpaxiotis commented 6 years ago

I built the basic functions of the Product class. I defined the price of the product as a float both as an instance variable and a class variable (override?). Is it ok?

ngiachou commented 6 years ago

Nice! Very good first try! I will review it tommorow and I will let you know.

You should also reference the issue that this PR solves. For example, solves #3

ngiachou commented 6 years ago

Good work @kpaxiotis but next time it is better to start a new branch for the staff you implement. Thanks!

kpaxiotis commented 6 years ago

Should I create a new brunch and build the class there or is it ok for now?

ngiachou commented 6 years ago

@kpaxiotis nicely done. Let's leave it on this branch, because with a new one a new Pull Request is needed to and it will get too complicated.