nginadofficial / open-video-ads

Automatically exported from code.google.com/p/open-video-ads
2 stars 3 forks source link

Issues with "applyToParts" config #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Reported by Scott Hendrickson - Sept 21

3) It also seems to me from testing that if I use the applyToParts on a dynamic 
playlist (I say 
dynamic because the number of videos is based on a database lookup) and choose 
for instance 
[0,3,6] as the 'parts' it will only play these if there is sufficient inventory 
and then if there is, it will 
play the first clip, skip the second and third, play the fourth clip, skip the 
fifth and sixth, play the 
seventh clip (all these with the configured ads)... then play the rest of the 
clips in the playlist. I had 
hoped that it would play all the clips only placing ads on those ones I have 
chosen...is that how it is 
supposed to work?

Original issue reported on code.google.com by paul.sch...@gmail.com on 26 Sep 2009 at 10:07

GoogleCodeExporter commented 9 years ago
Two separate issues here - firstly the bug - the applyToParts isn't working 
properly - secondly the 
"allowAdRepetition" needs to be specified at an ad server level, not a general 
ads level (the examples are wrong - 
they have now been fixed)

Original comment by paul.sch...@gmail.com on 26 Sep 2009 at 7:03

GoogleCodeExporter commented 9 years ago
Yep, there is a huge hole in the logic of StreamSequence.build() - the routine 
loops through the ad slots to add 
them into the streams, but if the ad slots are limited or do not map 1:1 to the 
streams, streams are skipped. 
Adding logic to ensure that any skipped streams are added before the next ad 
slot is processed. 

Original comment by paul.sch...@gmail.com on 27 Sep 2009 at 7:08

GoogleCodeExporter commented 9 years ago
Added test01.html to test a range of configuration options with applyToParts

Original comment by paul.sch...@gmail.com on 27 Sep 2009 at 9:02

GoogleCodeExporter commented 9 years ago
Fixed - see test01-12.html.

Significant fixes/changes to StreamSequence.build()

Original comment by paul.sch...@gmail.com on 3 Oct 2009 at 7:47