Closed Pearl1594 closed 2 years ago
Thanks @Pearl1594
Funtionality looks good, Your Python code uses 2 spaces as indentation. Please change this to 4 spaces.
Thanks @resmo for the review. I've updated the PR.
Merging #105 (8010fda) into master (50e9bc5) will decrease coverage by
0.23%
. The diff coverage is32.00%
.
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 84.04% 83.81% -0.24%
==========================================
Files 56 56
Lines 5616 5640 +24
Branches 1316 1324 +8
==========================================
+ Hits 4720 4727 +7
- Misses 454 468 +14
- Partials 442 445 +3
Impacted Files | Coverage Δ | |
---|---|---|
plugins/modules/cs_instance.py | 69.24% <32.00%> (-1.96%) |
:arrow_down: |
plugins/modules/cs_instance_nic.py | 88.37% <0.00%> (-1.17%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 50e9bc5...8010fda. Read the comment docs.
the sanity error does not seem to be related to this PR.
Addresses; https://github.com/ngine-io/ansible-collection-cloudstack/issues/100
How was it tested:
Created a VM passing pod and cluster name / id and it successfully created the VM in the specified cluster / pod
Translated to the following request on ACS end: