search

ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 27 forks source link

service_capabilities is a dict #120

Closed mattwillsher-f3 closed 1 year ago

mattwillsher-f3 commented 1 year ago

Network Offering -> service_capability is a dict, not a string. Conversion causes an error to be returned from the API.

resmo commented 1 year ago

Hi @mattwillsher-f3 , what is the version of cloudstack you run?

You might want to change not only the doc but python code here https://github.com/ngine-io/ansible-collection-cloudstack/blob/81e83e6a2f8ca5e76415f114ccb91b73f8fb6482/plugins/modules/cs_network_offering.py#L458

mattwillsher-f3 commented 1 year ago

CloudStack is 4.17. Was getting an issue with the dict that gets passed in getting converted to a string, then getting a 431 error back from the API.

Meant for this PR to go to my own repo for testing, didn't mean to create one in the main repo. I'm still testing, though the play got past the error when this change was applied.

mattwillsher-f3 commented 1 year ago

This changed fix the error in dev and I was able to verify via cmk list networkofferings

mattwillsher-f3 commented 1 year ago

I'll look at adding tests for this.