search

ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 28 forks source link

cs_project.py: pass cleanup=true in deleteProject API #122

Closed rohityadavcloud closed 1 year ago

rohityadavcloud commented 1 year ago

Pass cleanup=true in the delete project module, refer: https://cloudstack.apache.org/api/apidocs-4.18/apis/deleteProject.html

rohityadavcloud commented 1 year ago

cc @resmo

resmo commented 1 year ago

@weizhouapache well, didn't test it yet but in the past, cloudstack just ignored unknown flags? So for earlier versions, this shouldn't break backwards compatibility right?

weizhouapache commented 1 year ago

@weizhouapache well, didn't test it yet but in the past, cloudstack just ignored unknown flags? So for earlier versions, this shouldn't break backwards compatibility right?

@resmo this PR also works with the earlier cloudstack versions which do not support the cleanup flag.

There will be a warning message in log (just a warning) like

Received unknown parameters for command deleteProject. Unknown parameters : cleanup
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (dc89b6d) 83.77% compared to head (ac35926) 83.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #122 +/- ## ======================================= Coverage 83.77% 83.77% ======================================= Files 56 56 Lines 5645 5645 Branches 1271 1271 ======================================= Hits 4729 4729 Misses 472 472 Partials 444 444 ``` | [Impacted Files](https://app.codecov.io/gh/ngine-io/ansible-collection-cloudstack/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ngine-io) | Coverage Δ | | |---|---|---| | [plugins/modules/cs\_project.py](https://app.codecov.io/gh/ngine-io/ansible-collection-cloudstack/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ngine-io#diff-cGx1Z2lucy9tb2R1bGVzL2NzX3Byb2plY3QucHk=) | `83.72% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.