ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 27 forks source link

Adds additional supported_services in network offering #123

Closed bilalstanz closed 1 year ago

bilalstanz commented 1 year ago

Adds additional supported_services to the allowed list in cs_network_offering, tested NetworkACL service in cs 4.17

edit: attaching source link & screenshots

image

resmo commented 1 year ago

could you please fix "ERROR: plugins/modules/cs_network_offering.py:158:161: E501: line too long (166 > 160 characters)" by creating a yaml list item per line, like so

    supported_services: 
      - Dns
      - PortForwarding
      - Dhcp
      - SourceNat
      - UserData
      - Firewall
      - StaticNat
      - Vpn
      - Lb
      - NetworkACL
      - SecurityGroup
      - Connectivity
      - BaremetalPxeService
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c4f5525) 83.75% compared to head (db98e78) 83.75%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## ======================================= Coverage 83.75% 83.75% ======================================= Files 56 56 Lines 5645 5645 Branches 1271 1271 ======================================= Hits 4728 4728 Misses 474 474 Partials 443 443 ``` | [Files Changed](https://app.codecov.io/gh/ngine-io/ansible-collection-cloudstack/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ngine-io) | Coverage Δ | | |---|---|---| | [plugins/modules/cs\_network\_offering.py](https://app.codecov.io/gh/ngine-io/ansible-collection-cloudstack/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ngine-io#diff-cGx1Z2lucy9tb2R1bGVzL2NzX25ldHdvcmtfb2ZmZXJpbmcucHk=) | `88.17% <ø> (ø)` | | | [plugins/inventory/instance.py](https://app.codecov.io/gh/ngine-io/ansible-collection-cloudstack/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ngine-io#diff-cGx1Z2lucy9pbnZlbnRvcnkvaW5zdGFuY2UucHk=) | `78.75% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bilalstanz commented 1 year ago

did it, thanks

resmo commented 1 year ago

could you please provide a source where to find the list of supported services? or screenshot?

bilalstanz commented 1 year ago

added source link and screenshot in op

resmo commented 1 year ago

Thanks!