Closed resmo closed 4 years ago
man! that was quick.
Waiting for CI to pass, I don't expect this breaks anything for cloudstack <4.13.
I was looking at adding the test. But I am missing the IP range. I don't see anything in cs_common. Where are the ip_ranges?
I remember I file to boostrap the emulator somewhere... just cant find it.
Something seems off here. I cannot trace the start of the simulator from any file in this repo. Is it managed by the ansible-test distribution? Yes, in test/lib folder which is not in this repo....
How is that going to work once the collection is independent form ansible? in 2.10+
Merging #31 into master will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 84.40% 84.38% -0.02%
==========================================
Files 53 53
Lines 5509 5509
Branches 1246 1246
==========================================
- Hits 4650 4649 -1
Misses 432 432
- Partials 427 428 +1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c6348c...5091204. Read the comment docs.
this seems to be it: https://github.com/ansible/cloudstack-test-container/blob/1.2.0/zones.cfg Not sure why I am running 1.2.0 I guess my local ansible... on the tests now...
mmm can't push here... and PR from my fork created a new PR ins instead of modifying this.
the tests don't pass, I think due to 4.11 based simulator
mmm can't pull here...
its on quay.io, not on docker hub. yes, we need an updated simulator to actually test this
Ci passed and I don't have any concerns it could break anything. Merging...
Thanks!
Closes #30 /cc @rvalle
Todos: