search

ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 28 forks source link

Multiple CIDRs not working in VPC ACLs #41

Closed rvalle closed 3 years ago

rvalle commented 3 years ago

ACLs break if they specify multiple CIDRs, at least for Egress rules on VPCs I can see in the UI that they are posted with several CIDRs separated by commas

When I add the second CIDR, the ACL breaks.

I am not sure if this is an Ansible module issue or an ACS, could be related to: https://github.com/apache/cloudstack/issues/4402

I have checked the API and it takes a list. I am not sure if we are translating it in a way that ACS likes it, or if ACS is failing to take a CIDR list on the ACL....

resmo commented 3 years ago

~I fixed this some time ago for some modules e.g. for cs_firewall https://github.com/ngine-io/ansible-collection-cloudstack/blob/master/plugins/modules/cs_firewall.py#L49. See https://github.com/ansible/ansible/pull/33020/~

Sorry, didn't checked the module, regarding the module, this should be implemented. See tests https://github.com/ngine-io/ansible-collection-cloudstack/blob/master/tests/integration/targets/cs_network_acl_rule/tasks/main.yml#L198

rvalle commented 3 years ago

Our tests pass because the ACS Management server accepts the calls.

However, the problem is that the ACLs are not translated into VR Rules that actually work.

We would then say that the problem is on ACS side, right?

resmo commented 3 years ago

I would say so, yes.

rvalle commented 3 years ago

Lets close this issue as this is in fact an ACS issue by not meeting its own specification.