search

ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 28 forks source link

Fix to allow optional cloudstack.ini to be missing #56

Closed resmo closed 3 years ago

resmo commented 3 years ago

@rvalle didn't you create a PR with this exact change?

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 (88dec93) into master (2859ce0) will increase coverage by 0.07%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   84.32%   84.39%   +0.07%     
==========================================
  Files          53       53              
  Lines        5512     5512              
  Branches     1247     1247              
==========================================
+ Hits         4648     4652       +4     
+ Misses        433      430       -3     
+ Partials      431      430       -1
Impacted Files Coverage Δ
plugins/module_utils/cloudstack.py 72.80% <0.00%> (ø)
plugins/modules/cs_instance.py 71.52% <0.00%> (+0.68%) :arrow_up:
plugins/modules/cs_router.py 61.98% <0.00%> (+0.82%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2859ce0...88dec93. Read the comment docs.

rvalle commented 3 years ago

@resmo sorry didn't see your question back them. I created a similar PR but arrived to this patch while trying to make inventory and modules use the same logic. I just wondered why that exception was missing and created an unit test with all possible auth cases.