Closed rvalle closed 3 years ago
Merging #61 (cdc82d3) into master (badff84) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 53 53
Lines 5500 5500
Branches 1246 1246
=======================================
Hits 4639 4639
Misses 431 431
Partials 430 430
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update badff84...94bd4de. Read the comment docs.
@resmo you can review now if you want. I just have one more thing to do. I have a list of use cases of grouping and filtering that I want to check are viable with the selected inner template of the inventory plugin.
@resmo, the pending coverage issue is telling us that we need a test where authentication fails (missing key or secret). I am find with adding it, but I wonder why didn't we get this message before (?)
the sanity fails because bumping to 2.0.0 requires #60
this PR has a dependency on #62 because of the deprecation thing.
I will rebase the PR to the new 2.0
@resmo I have rebased to v2, still WIP
It is not clear how to configure the environment plugin: no idea how to implement environment fallback for this kind of plugin, it is currently WIP.
PR replaced by #66 for the purpose of cleaning the branch
This PR provides: