search

ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 28 forks source link

cs_instance: expend all items for ipv6 and mac for ip_to_networks #81

Closed resmo closed 3 years ago

resmo commented 3 years ago

Fixes #78 /cc @jdinner if you have a chance to test this, I would appreciate your feedback

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (e3b76f1) into master (d16c15f) will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   84.25%   84.24%   -0.02%     
==========================================
  Files          56       56              
  Lines        5597     5597              
  Branches     1255     1255              
==========================================
- Hits         4716     4715       -1     
  Misses        445      445              
- Partials      436      437       +1
Impacted Files Coverage Δ
plugins/modules/cs_instance.py 71.52% <0.00%> (ø)
plugins/modules/cs_router.py 61.15% <0.00%> (-0.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d16c15f...e3b76f1. Read the comment docs.

jdinner commented 3 years ago

Hi, sorry about long delay. Vacation time! I really like to test it, but I'm not sure how. Should I clone repository into ~/.ansible/collections/ansible_collections/ngine_io/cloudstack? Or something else? When, after I test it, will be this repaired version in ansible galaxy?

jdinner commented 3 years ago

I just tried it this way and it's work as I expected. MAC address is set to right value and SW license works. Thanks! Is it possible to release something like v2.1.1 and push it to ansible-galaxy?

resmo commented 3 years ago

@jdinner great, thanks for your feedback. I'll release v2.2.0 which gets pushed to galaxy.