ngine-io / ansible-collection-cloudstack

CloudStack Ansible Collections
https://galaxy.ansible.com/ngine_io/cloudstack
GNU General Public License v3.0
21 stars 27 forks source link

Added project ID to volume query when checking root disk size. #90

Closed kovukono closed 2 years ago

kovukono commented 2 years ago

At the moment, if specifying a size for a root drive of an instance, any attempt to rerun the playbook will fail on currently-deployed instances if the VM is deployed outside of the root project. This PR makes sure the volumes query is within the same project as the VM it's trying to determine the root volume size of.

codecov[bot] commented 2 years ago

Codecov Report

Merging #90 (4430658) into master (f3e6e85) will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   84.15%   84.13%   -0.02%     
==========================================
  Files          56       56              
  Lines        5611     5611              
  Branches     1260     1260              
==========================================
- Hits         4722     4721       -1     
- Misses        446      448       +2     
+ Partials      443      442       -1     
Impacted Files Coverage Δ
plugins/modules/cs_instance.py 71.20% <0.00%> (ø)
plugins/module_utils/cloudstack.py 71.36% <0.00%> (-0.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3e6e85...4430658. Read the comment docs.

resmo commented 2 years ago

@kovukono Thanks!