ngine-io / ansible-collection-exoscale

Exoscale Ansible Collection
https://galaxy.ansible.com/ngine_io/exoscale
0 stars 2 forks source link

Add module for reverse DNS on exoscale VMs #6

Closed znerol closed 4 years ago

znerol commented 4 years ago

Migrated from PR ansible/ansible#57319

znerol commented 4 years ago

What is the significance of version_added metadata field with this new project structure?

znerol commented 4 years ago

From the sanity test log:

2020-08-18T13:57:00.6559686Z ERROR: Command "/usr/bin/python3.6 /root/ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate-modules --format json --arg-spec plugins/modules/exo_dns_domain.py plugins/modules/exo_dns_record.py plugins/modules/exo_rdns_record.py --collection ansible_collections/ngine_io/exoscale --collection-version 1.0.0" returned exit status 1.
2020-08-18T13:57:00.6560089Z >>> Standard Error
2020-08-18T13:57:00.6560221Z Traceback (most recent call last):
2020-08-18T13:57:00.6562615Z   File "/root/ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate-modules", line 8, in <module>
2020-08-18T13:57:00.6562880Z     main()
2020-08-18T13:57:00.6563554Z   File "/root/ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py", line 2444, in main
2020-08-18T13:57:00.6563730Z     run()
2020-08-18T13:57:00.6564171Z   File "/root/ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py", line 2341, in run
2020-08-18T13:57:00.6564428Z     mv1.validate()
2020-08-18T13:57:00.6564869Z   File "/root/ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py", line 2145, in validate
2020-08-18T13:57:00.6565041Z     doc_info, docs = self._validate_docs()
2020-08-18T13:57:00.6565473Z   File "/root/ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py", line 986, in _validate_docs
2020-08-18T13:57:00.6565917Z     add_fragments(doc, self.object_path, fragment_loader=fragment_loader, is_module=True)
2020-08-18T13:57:00.6566126Z   File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 198, in add_fragments
2020-08-18T13:57:00.6566838Z     raise AnsibleError('unknown doc_fragment(s) in file {0}: {1}'.format(filename, to_native(', '.join(unknown_fragments))))
2020-08-18T13:57:00.6567235Z ansible.errors.AnsibleError: unknown doc_fragment(s) in file plugins/modules/exo_rdns_record.py: cloudstack
znerol commented 4 years ago

The exo_rdns_record to be introduced in this PR has dependencies on ansible.module_utils.cloudstack. Looks like this has been migrated to ngine-io/ansible-collection-cloudstack

resmo commented 4 years ago

adding a collection dependency is also new to me, I'll try to find out how this works ;)

znerol commented 4 years ago

Does the sanity workflow actually install dependencies? Is this a responsibility of ansible-test when preparing the docker images?

znerol commented 4 years ago

ansible-collections/community.aws has some dependencies, but they pull them in using a mix of git and ansible-galaxy commands.

znerol commented 4 years ago

Sanity is back green. Regrettably I cannot test this against a real exoscale instance since I currently do not maintain any infra running there.

resmo commented 4 years ago

@znerol perfect, I have an account where I can run tests, should have time today to do so. I'll let you know

resmo commented 4 years ago

I just noticed another thing to fix: there is API for adding reverse dns for public IPs: queryReverseDnsForPublicIpAddress: we should rename this module to not collide with the names. suggestion: instance_rdns_record?

(I'd like also to get rid of the exo_ prefix for new and change existing in the long term because we have namespacing built in in collections)

resmo commented 4 years ago

Thanks for your efforts!