search

ngine-io / ansible-collection-vultr

Vultr Ansible Collections
https://galaxy.ansible.com/ngine_io/vultr
GNU General Public License v3.0
16 stars 11 forks source link

Feature/vultr lb #3

Closed jstoja closed 2 years ago

jstoja commented 4 years ago
SUMMARY

Implement Vultr Load Balancer API (https://www.vultr.com/api/#loadbalancer)

From https://github.com/ansible-collections/community.general/pull/159

ISSUE TYPE
COMPONENT NAME

vulr_lb

ADDITIONAL INFORMATION

Goal is something like this:

- vultr_lb:
    dcid: 1
    algorithm: Leastconn
    label: web
    state: present
    forwarding_rules:
      - frontend_protocol: https
        frontend_port: 81
        backend_protocol: https
        backend_port: 81
resmo commented 4 years ago

Thanks for your contribution, let me know if I can help to get the santiy CI through. There is an issue with the later tests "integration test using python ..." currently don't expect this to succeed.

jstoja commented 4 years ago

I saw that I can still improve the documentation as the type field isn't correct. I should explicit those fields with suboptions from what I could find in the ansible documentation.

resmo commented 4 years ago

yes, see https://github.com/ansible-collections/azure/blob/dev/plugins/modules/azure_rm_securitygroup.py#L619 as example

jstoja commented 4 years ago

@resmo It seems that the integrations tests are failing but aren't linked to my changes:

Running vultr_account_info integration test role
ERROR: No section: 'default'
ERROR: The 1 integration test(s) listed below (out of 1) failed. See error output above for details:
vultr_account_info

Can you confirm?

resmo commented 4 years ago

yes, I confirm.

resmo commented 2 years ago

Thank you very much for your contribution.

In the meantime, Vultr has deprecated the v1 API and we have been working with @vultr to re-implement the modules with the v2 API.

Therefore, this collection is now in maintenance mode and we encourage you to contribute new feature now here https://github.com/vultr/ansible-collection-vultr/.