search

nginx-proxy / nginx-proxy

Automated nginx proxy for Docker containers using docker-gen
MIT License
18.13k stars 3k forks source link

feat: custom default error page #2430

Closed buchdag closed 1 week ago

buchdag commented 4 weeks ago

This PR allows to customise the default error page by mounting an HTML file to serve in its place.

Solve #1325

buchdag commented 2 weeks ago

I'm not certain this PR should restore the nginx image's 50x page by default.

This would switch from this, which have been there since the beginning :

79203896-fd88e980-7e3b-11ea-9147-44908aa3e665

To this:

image

That's arguably easier to the eye but that might not be what users want as default either.

@Prime1Code any opinion on this ?

Prime1Code commented 2 weeks ago

Yes, I think so too. This error page should not be enabled by default.

But the option to add one is still a better customization option than without it.