search

nginx-shib / nginx-http-shibboleth

Shibboleth auth request module for nginx
https://github.com/nginx-shib/nginx-http-shibboleth/wiki
Other
209 stars 27 forks source link

Fix compatibility with nginx 1.23.0+ #50

Closed heikojansen closed 1 year ago

heikojansen commented 2 years ago

This pull requests includes the same fixes I mentioned in issue #48 but with proper references to their origin in openresty/headers-more-nginx-module where they were created and contributed by other people.

Besides me a few other users of ngx_http_shibboleth independently verified that these changes are sufficient to fix the core dumps apparently caused by the changes made in nginx 1.23.0 concerning the internal representation of headers.

tmcqueen-materials commented 2 years ago

I am one of those users that can confirm this resolves the crashes with nginx 1.23.1 .

craig-riecke commented 1 year ago

+1. We have been using the fix for two weeks now with no issues.

davidjb commented 1 year ago

Thanks so much @heikojansen - this looks great. I've rebased your changes on the latest master after updating the CI builds to build 1.23.x (requiring a newer compatible headers-more module also). Everything looks good so this is merged. Thanks again!

Thanks also to you both @tmcqueen-materials and @craig-riecke for your testing and insight.