search

nginx-shib / nginx-http-shibboleth

Shibboleth auth request module for nginx
https://github.com/nginx-shib/nginx-http-shibboleth/wiki
Other
211 stars 27 forks source link

Building for -v 1.18.0 fails due to incorrect changelog filename #51

Open mkpelletier opened 2 years ago

mkpelletier commented 2 years ago

Description the bug

Using pkg-oss, build for nginix-1.18.0 fails due to incorrect changelog references in Makefiles

Expected behaviour

Building for this particular version should complete successfully with Makefiles referring to nginx-module-shibboleth.changelog.in instead of nginx-module-shibboleth.deb-changelog

Steps to Reproduce Issue

  1. run ./build_module.sh -v 1.18.0 https://github.com/nginx-shib/nginx-http-shibboleth.git
  2. make fails with error.
  3. check Makefile and see that it refers to nginx-module-shibboleth.deb-changelog.
  4. check changelog name in directory and see that the file name is actually nginx-module-shibboleth.changelog.in.

Setup & Logs

...

Saving to: ‘nginx-1.18.0.tar.gz’

nginx-1.18.0.tar.gz 100%[==============================================================================================================>] 1015K 937KB/s in 1.1s

2022-08-24 12:34:17 (937 KB/s) - ‘nginx-1.18.0.tar.gz’ saved [1039530/1039530]

Build environment has been created in: /home/ubuntu/debuild

Please do the following in order to get available build targets: cd /home/ubuntu/debuild/nginx-1.18.0/debian make ===> Generating nginx-module-shibboleth.deb-changelog make[1]: Entering directory '/home/ubuntu/debuild/nginx-1.18.0/docs' make[1]: No rule to make target '/home/ubuntu/debuild/nginx-1.18.0/debian/nginx-module-shibboleth.deb-changelog'. Stop. make[1]: Leaving directory '/home/ubuntu/debuild/nginx-1.18.0/docs' make: [Makefile:156: nginx-module-shibboleth.deb-changelog] Error 2

Versions and Systems

nginx version: nginx/1.18.0 (Ubuntu) Ubuntu 20.04

Additional context

When building for either version 1.17.10 or 1.19.0 (versions on either end of 1.18.0) build is successful. In these, the changelog produced is nginx-module-shibboleth.changelog.in as expected and referenced in Makefiles.

davidjb commented 1 week ago

This sounds like it’s a pkg-oss issue if previous versions were working and later versions are working now, but also the symptom of it looking for an explicit .deb changelog. Perhaps they’ve pushed a fix to the 1.18 branch in the meantime.