search

nginx / nginx.org

Sources for the NGINX website and documentation
https://nginx.org
Other
48 stars 18 forks source link

Fixed broken link for Admin's Guide. #24

Closed Robb-Fr closed 3 months ago

Robb-Fr commented 3 months ago

This current link to Admin's Guide (https://www.nginx.com/resources/admin-guide/) leads to a 404 not found web page. This new link (https://docs.nginx.com/nginx/admin-guide/) seems to be the intended destination.

Robb-Fr commented 3 months ago

Hello @y82 ! Thanks a lot for your detailed and kind feedback. If I understood it correctly, the required changed should be implemented! Sorry for missing the style guide, let me know if I missed something.

y82 commented 3 months ago

Hi @Robb-Fr,

Thank you for implementing the feedback - it's all correct except 1 style comment, see README.md: "Review feedback is implemented into the same patch, do not include a separate patch with the review in the PR. " In other words, the current rule is 1patch inside 1pr. So you need to merge the 3 patches into 1 with the commit log "Fixed broken link for Admin's Guide."

Robb-Fr commented 3 months ago

Hey @y82 Sorry for misunderstanding this part, I think I finally got it! Let me know if anything else is missing. Thanks for your time!

y82 commented 3 months ago

Hi @Robb-Fr, Thank you, all good now, the patch was committed to the repo.