Closed lcrilly closed 2 months ago
You forgot to include (removal of) xslt/banner.xslt after the previous change.
Yes I did. Thanks for catching that. I will close this and resubmit a clean PR with just 2 commits (changes + regeneration).
@fblr anything from you?
Originally, the banner was implemented within xsls/body.xsls - the commit history for this file shows the banner changes over the years.
More recently, commit d183d61 replaced the banner with HTML content that is loaded with a JavaScript fetch() call, after the page load. The intention was to enable conditional banner selection but this facility has not been used.
Unfortunately, the post-load fetch() results in an unpleasant page layout shift.
This patch reverts to an XML-based banner, built into each page during the site generation process. It retains the benefit introduced with the separate HTML file by placing the banner content in xml/banner.xml