nginx / nginx.org

Sources for the NGINX website and documentation
https://nginx.org
Other
48 stars 18 forks source link

Banner: Replaced dynamic loading with permanent addition to layout. #52

Closed lcrilly closed 2 months ago

lcrilly commented 2 months ago

Originally, the banner was implemented within xsls/body.xsls - the commit history for this file shows the banner changes over the years.

More recently, commit d183d61 replaced the banner with HTML content that is loaded with a JavaScript fetch() call, after the page load. The intention was to enable conditional banner selection but this facility has not been used.

Unfortunately, the post-load fetch() results in an unpleasant page layout shift.

This patch reverts to an XML-based banner, built into each page during the site generation process. It retains the benefit introduced with the separate HTML file by placing the banner content in xml/banner.xml