nginx / njs-acme

Nginx NJS module runtime to work with ACME providers like Let's Encrypt for automated no-reload TLS certificate issue/renewal.
Apache License 2.0
57 stars 9 forks source link

Validate hostnames given in `NJS_ACME_SERVER_NAMES` #15

Closed zsteinkamp closed 1 year ago

zsteinkamp commented 1 year ago

Currently, we will split the value of NJS_ACME_SERVER_NAMES on space/comma and blindly use the result to request certs.

Since the HTTP-01 challenge type only supports full hostnames and not wildcard names, we should:

ivanitskiy commented 1 year ago

we also need to consider checking the following:

zsteinkamp commented 1 year ago

I'll open a new issue for that. 👍