run Integration tests in CI - Githubissues

nginx / njs-acme

Nginx NJS module runtime to work with ACME providers like Let's Encrypt for automated no-reload TLS certificate issue/renewal.

Apache License 2.0

70 stars 11 forks source link

run Integration tests in CI #22

Closed ivanitskiy closed 1 year ago

ivanitskiy commented 1 year ago

Proposed changes

Run unit tests and integration tests in CI (and only in CI)
Added health checks for pebble container to use the service_healthy condition in depende_on properly
separate the mocha config file into two: unit and integration tests files
allow to use of specified nginx bin path when running integration tests as nginx-testing still has no support for NJS v0.8.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[x] I have updated any relevant documentation (README.md and CHANGELOG.md)

jirutka commented 1 year ago

allow to use of specified nginx bin path when running integration tests as nginx-testing still has no support for NJS v0.8.0

This is already fixed (nginx-binaries provides nginx 1.24.x and 1.25.x with njs 0.8.0), so you can revert these unnecessary Dockerfails. ;) Next time please open an issue; I would have resolved it sooner if I knew it was being used in this project.