nginx / njs-acme

Nginx NJS module runtime to work with ACME providers like Let's Encrypt for automated no-reload TLS certificate issue/renewal.
Apache License 2.0
57 stars 9 forks source link

Added built-in certificates autorenewal #35

Closed fabriziofiorucci closed 5 months ago

fabriziofiorucci commented 1 year ago

Proposed changes

This PR adds automated certificates renewal. Adding one internal server {} and upstream {} enables a self-contained solution to periodically send GET requests to /acme/auto

Checklist

Before creating a PR, run through this checklist and mark each as complete.

ivanitskiy commented 12 months ago

I'm wondering if this current PR is beneficial as there is @zsteinkamp's WIP https://github.com/nginx/njs-acme/pull/38 that would use the new capabilities of NJS to schedule periodic work.

zsteinkamp commented 12 months ago

Agreed that the solution in #38 (which depends on njs-0.8.1 capabilities, to be released Sep 12) is overall better for customers since it's completely self-contained.

zsteinkamp commented 5 months ago

Thanks @fabriziofiorucci! We have merged #38 which implements auto-renewal.