search

nginx / njs-acme

Nginx NJS module runtime to work with ACME providers like Let's Encrypt for automated no-reload TLS certificate issue/renewal.
Apache License 2.0
57 stars 9 forks source link

jirutka/nginx-binaries has NJS 0.8.0 so we can update Dockerfile for CI testing #36

Closed ivanitskiy closed 5 months ago

ivanitskiy commented 1 year ago 
          > allow to use of specified nginx bin path when running integration tests as nginx-testing still has no support for NJS v0.8.0

This is already fixed (nginx-binaries provides nginx 1.24.x and 1.25.x with njs 0.8.0), so you can revert these unnecessary Dockerfails. ;) Next time please open an issue; I would have resolved it sooner if I knew it was being used in this project.

Originally posted by @jirutka in https://github.com/nginx/njs-acme/issues/22#issuecomment-1687200036

ivanitskiy commented 1 year ago

would be helpful to convert this to the latest NJS from sources to catch issues like this: https://github.com/nginxinc/nginx-s3-gateway/actions/runs/5957186819/job/16159400471#step:7:3122

Another aspect is that we need to test against "official" builds that NGINX distributed (both OSS and Plus) to cover. that being said I'm not against using the binaries from nginx-binaries, rather expand the matrix of options